Hello,

I just entered the ML to complain that I can't manage to compile rsyslog
(more on that on another thread). But if Cristian tested it - thanks! :)

One comment about supporting 0.90, though: I wouldn't bother. Elasticsearch
(the company) will drop support for it soon, few people use it now, and
even fewer in the future. I wouldn't bloat the code by even trying to
support it, especially if the only broken thing is the error file. I'm
99.9999% sure no-one will complain.

--
Performance Monitoring * Log Analytics * Search Analytics
Solr & Elasticsearch Support * http://sematext.com/


On Tue, Aug 26, 2014 at 5:21 PM, Rainer Gerhards <[email protected]>
wrote:

> On Tue, Aug 26, 2014 at 4:00 PM, Cristian Falcas <[email protected]>
> wrote:
>
> > With 0.9.13 the files are still spammed with what looks like correct
> > responses.
> >
> > ES 0.9 ok message:
> >
> >                                 "create":       {
> >                                         "_index":       "2014-08-26",
> >                                         "_type":        "audispd",
> >                                         "_id":  "r0J0_gwWR8qryEISI4uMKg",
> >                                         "_version":     1,
> >                                         "ok":   true
> >                                 }
> >
> > Es 1.x ok message:
> >                                 "create":       {
> >                                         "_index":       "2014-08-26",
> >                                         "_type":        "auth",
> >                                         "_id":  "b4sd8yfsTROqKFLvbyzMjg",
> >                                         "_version":     1,
> >                                         "status":       201
> >                                 }
> >
> >
> ah, I somehow had the feeling that "ok" was not really redundant (as said
> in the ES API doc) ;)
>
>
> > It seems that the fix should include both checks
> > ok = cJSON_GetObjectItem(create, "ok");
> > and
> > ok = cJSON_GetObjectItem(create, "status");
> >
> > I presume that status is always defined in 1.x, so if that one is missing
> > it should be interpreted that it's a 0.9 es server?
> >
>
> sounds like a good plan!
> Thx
> Rainer
>
> >
> > Best regards,
> >
> >
> >
> >
> > On Tue, Aug 26, 2014 at 3:44 PM, Rainer Gerhards <
> [email protected]
> > >
> > wrote:
> >
> > > On Tue, Aug 26, 2014 at 2:40 PM, Cristian Falcas <
> > [email protected]>
> > > wrote:
> > >
> > > > We only have 1.3.1 deployed, sorry. If testing with 0.9 is blocking
> the
> > > > integration of the patch, I will try to install 0.9 somewhere and
> test
> > > it.
> > > >
> > > >
> > > that would be great. I think I cannot merge the patch with the risk of
> > > causing problems to installations that so far worked. That would be an
> > > extreme surprise for those users.
> > >
> > > Rainer
> > > _______________________________________________
> > > rsyslog mailing list
> > > http://lists.adiscon.net/mailman/listinfo/rsyslog
> > > http://www.rsyslog.com/professional-services/
> > > What's up with rsyslog? Follow https://twitter.com/rgerhards
> > > NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a
> myriad
> > > of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you
> > > DON'T LIKE THAT.
> > >
> > _______________________________________________
> > rsyslog mailing list
> > http://lists.adiscon.net/mailman/listinfo/rsyslog
> > http://www.rsyslog.com/professional-services/
> > What's up with rsyslog? Follow https://twitter.com/rgerhards
> > NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad
> > of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you
> > DON'T LIKE THAT.
> >
> _______________________________________________
> rsyslog mailing list
> http://lists.adiscon.net/mailman/listinfo/rsyslog
> http://www.rsyslog.com/professional-services/
> What's up with rsyslog? Follow https://twitter.com/rgerhards
> NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad
> of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you
> DON'T LIKE THAT.
>
_______________________________________________
rsyslog mailing list
http://lists.adiscon.net/mailman/listinfo/rsyslog
http://www.rsyslog.com/professional-services/
What's up with rsyslog? Follow https://twitter.com/rgerhards
NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of 
sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE 
THAT.

Reply via email to