On Tue, Aug 19, 2014 at 3:16 PM, Michael Biebl <[email protected]> wrote:
> Hi, > > I suggest to add small tweaks to the systemd service file: > > > diff --git a/rsyslog.service.in b/rsyslog.service.in > index 8e2d64c..de37ff0 100644 > --- a/rsyslog.service.in > +++ b/rsyslog.service.in > @@ -1,11 +1,14 @@ > [Unit] > Description=System Logging Service > Requires=syslog.socket > +Documentation=man:rsyslogd(8) man:rsyslog.conf(8) > +Documentation=http://www.rsyslog.com/doc/ > > [Service] > Type=notify > ExecStart=@sbindir@/rsyslogd -n > StandardOutput=null > +Restart=on-failure > > [Install] > WantedBy=multi-user.target > > > > > The first one is adding a Documentation field. I'm a bit unsure if we > should actually add man:rsyslog.conf(8) here, since that file is > pretty outdated (in v8.4). Adding man:rsyslogd(8) at least seems fine > though. > Regarding the link to the documentation hosted on the web site: We can > use the unversioned > http://www.rsyslog.com/doc/ here or actually match the correct version > like in case of 8.4 > http://www.rsyslog.com/doc/v8-stable/. > > I have finally merged this, makes a lot of sense. I have removed the rsyslog.conf man page -- we should find a way to generate a better one based on the doc project. So far, I've used the generic doc, but there would potentially be some plus in being version specific. Does it make sense to apply these tweak to v7 as well? Rainer > This would require though, to keep the rsyslog.service.in up-to-date > with each new release. > > > > The result then looks like > > rsyslog.service - System Logging Service > Loaded: loaded (/lib/systemd/system/rsyslog.service; enabled) > Active: active (running) since Di 2014-08-19 14:58:59 CEST; 15min ago > Docs: man:rsyslogd(8) > man:rsyslog.conf(8) > http://www.rsyslog.com/doc/ > Main PID: 14416 (rsyslogd) > CGroup: /system.slice/rsyslog.service > └─14416 /usr/sbin/rsyslogd -n > > > > The second is the addition of Restart=on-failure [1] > I think having rsyslog respawned when it crashes makes a lot of sense > for a syslogger. > > > Michael > > [1] > http://www.freedesktop.org/software/systemd/man/systemd.service.html#Restart= > -- > Why is it that all of the instruments seeking intelligent life in the > universe are pointed away from Earth? > _______________________________________________ > rsyslog mailing list > http://lists.adiscon.net/mailman/listinfo/rsyslog > http://www.rsyslog.com/professional-services/ > What's up with rsyslog? Follow https://twitter.com/rgerhards > NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad > of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you > DON'T LIKE THAT. _______________________________________________ rsyslog mailing list http://lists.adiscon.net/mailman/listinfo/rsyslog http://www.rsyslog.com/professional-services/ What's up with rsyslog? Follow https://twitter.com/rgerhards NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
