Hi Rainer, David, Do the patches look ok?
On Fri, Oct 17, 2014 at 3:56 PM, singh.janmejay <[email protected]> wrote: > > > On Tue, Oct 14, 2014 at 12:18 PM, singh.janmejay <[email protected] > > wrote: > >> Yes, I'll make necessary changes and send the patch again. >> >> -- >> Regards, >> Janmejay >> >> PS: Please blame the typos in this mail on my phone's uncivilized soft >> keyboard sporting it's not-so-smart-assist technology. >> On Oct 14, 2014 12:02 PM, "Rainer Gerhards" <[email protected]> >> wrote: >> >>> 2014-10-14 8:30 GMT+02:00 singh.janmejay <[email protected]>: >>> >>> > > > - replace(operand, substring_to_be_replaced, its_replacement) >>> > > > - wrap(operand, string_to_wrap_around_it) >>> > > > >>> > > >>> > > - concat(operand_1, operand_2) >>> > > > >>> > > >>> > > >>> > > I think you overlooked the concatenation operation. you can simply do >>> > > >>> > > operand1 & operand2 >>> > > >>> > > eg: "foo" & "bar" ==> "foobar" >>> > > >>> > > I think concat() is equivalent to this. Am I right? >>> > > >>> > >>> > It is the same. I didn't know it was available as an operator, my bad. >>> Will >>> > remove the concat implementation in the reworked patch. >>> > >>> >>> yeah the doc is pretty sparse. >>> >>> If I understand you correctly, I will wait for a new patch set before >>> merging the existing one. Right? >>> >>> Rainer >>> _______________________________________________ >>> rsyslog mailing list >>> http://lists.adiscon.net/mailman/listinfo/rsyslog >>> http://www.rsyslog.com/professional-services/ >>> What's up with rsyslog? Follow https://twitter.com/rgerhards >>> NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad >>> of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you >>> DON'T LIKE THAT. >>> >> > > Hi, > > Sorry for breaking the continuation here, I finally managed to get some > time to work on this today. > > Patches are attached. Just for clarity, I am attaching all(actually 2) > relevant patches(even though one of them is not changed). > > Changes made: > - removed the patch that implemented concat > - enhanced the wrap method to have 2 variants wrap(str, wrapper) and > wrap(str, wrapper, wrapper_escape) > - kept the replace (and wrap first cut) patch untouched. > > > -- > Regards, > Janmejay > http://codehunk.wordpress.com > -- Regards, Janmejay http://codehunk.wordpress.com _______________________________________________ rsyslog mailing list http://lists.adiscon.net/mailman/listinfo/rsyslog http://www.rsyslog.com/professional-services/ What's up with rsyslog? Follow https://twitter.com/rgerhards NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
