On 01/16/15 12:05, Florian Riedl wrote:
Hi all,
We have just released liblognorm 1.1.0.
I've checked out the new release and there are couple of things that I
think need to be sorted out. I'll start filing PRs for those confirmed
to be real bugs.
The link at http://www.liblognorm.com/download/ actually points to
1.0.1. I guess this is why Upstream Tracker didn't pick it up.
The library (as in soname) is incorrectly versioned. The current version is:
liblognorm_la_LDFLAGS = -version-info 1:0:0
It wasn't updated since 0.4.0 even though the interface has been
changed. Updating the version should be part of the release process and
not doing so would cause issues for the consumers of this lib.
This is not the only github.com/rsyslog/lib* with this problem.
Some details about the versioning mechanism are here[0].
I've noticed that liblognorm.h references struct json_object without
including json.h. This doesn't seem to break compilation of mmnormalize
only because the module itself includes json.h before including
liblognorm.h.
liblognorm.h includes libestr.h without an apparent need. The lognorm.h
header seems to require libestr.h withouth including it - but it
includes liblognorm.h so things kind of work.
The headers distributed with liblognorm are scattered all over
/usr/include. Using a single directory would be preferable.
Are all the headers that are distributed[1] really mean to be public?
Tomas
[0] https://www.sourceware.org/autobook/autobook/autobook_91.html
[1] include_HEADERS = liblognorm.h samp.h lognorm.h ptree.h annot.h
enc.h parser.h lognorm-features.h
_______________________________________________
rsyslog mailing list
http://lists.adiscon.net/mailman/listinfo/rsyslog
http://www.rsyslog.com/professional-services/
What's up with rsyslog? Follow https://twitter.com/rgerhards
NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of
sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE
THAT.
