2015-01-19 12:32 GMT+01:00 Thomas D. <[email protected]>:

> Hi,
>
> Rainer wrote:
> > Does the failing test mean we no longer can commit?
>
> No. Travis will be triggered after someone pushes something...
>
> So Travis is unable to block a bad commit.
>
> That's why using a PR workflow for everything in future is recommended, so
> everything gets tested (if you commit without a PR, it will trigger a
> build,
> too... but you have to check notifications to see that your last commit
> broke something...).
>
>
Yeah, I played a bit with the integration on my personal repository on
github. From past conversation, I was under the impression that this will
be a very tight integration that ensures no bad commit can happen. As I now
understand it, it's simply running side-by-side as an optional component.
That also means there is much less risk enabling the system than I
initially thought :-)

That's still nice, but it's much close to what I do with the testbench,
now, just being scheduled more often. It also looks like CI and the
testbench complement each other. With travis, I seem to be unable to run on
a variety of platforms besides ubuntu and (experimentally) mac OS X.

I hadn't a chance yet to play with pull requests. Will there be a visual
indication on a per-pull-request basis *on github* if it was problematic,
or do I need to check the travis site?

Thanks,
Rainer

>
> -Thomas
>
>
> _______________________________________________
> rsyslog mailing list
> http://lists.adiscon.net/mailman/listinfo/rsyslog
> http://www.rsyslog.com/professional-services/
> What's up with rsyslog? Follow https://twitter.com/rgerhards
> NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad
> of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you
> DON'T LIKE THAT.
>
_______________________________________________
rsyslog mailing list
http://lists.adiscon.net/mailman/listinfo/rsyslog
http://www.rsyslog.com/professional-services/
What's up with rsyslog? Follow https://twitter.com/rgerhards
NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of 
sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE 
THAT.

Reply via email to