2015-01-27 19:01 GMT+01:00 Thomas D. <[email protected]>: > Hello, > > Rainer wrote: > > HOWEVER, it is correct that the testbench does not throw an error, > > because the config is to NOT abort on errors. So in that regard it > > works like it should. > > ...wait, to be clear: > > 1) It is one thing to run *all* the tests and don't break on the first > error. > That would be OK! > > 2) But "make check" should never ever return 0 when at least one test > failed. > That would be wrong. >
no test failed, that's the point ;) > > 3) The test scripts should check rsyslogd's exit value (and any other exit > values from commands they call). If rsyslogd exit with a non-zero exit code > (like what will happen when rsyslogd will throw an CONFIG ERROR) the script > should detect that and the test should fail. > yup > > > I am not sure, do we disagree in one point? > > I guess a misunderstanding. By default, rsyslog does NOT error-exit because of a simple typo in the config. Granted, this may mean some action is not or not correctly carried out, but if it failed, no logging would occur at all. If you like this, you can turn that on. But in the tests, it's not turned on, and so nothing failed. Hope that clarifies. Rainer _______________________________________________ rsyslog mailing list http://lists.adiscon.net/mailman/listinfo/rsyslog http://www.rsyslog.com/professional-services/ What's up with rsyslog? Follow https://twitter.com/rgerhards NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
