2015-03-10 21:35 GMT+01:00 Michael Biebl <[email protected]>: > tcpflood_SOURCES = tcpflood.c > tcpflood_CPPFLAGS = $(PTHREADS_CFLAGS) $(GNUTLS_CFLAGS) > tcpflood_LDADD = $(SOL_LIBS) $(PTHREADS_LIBS) $(GNUTLS_LIBS) > if ENABLE_GNUTLS > tcpflood_LDADD += -lgcrypt > endif > > > That looks broken. ENABLE_GNUTLS doesn't imply that gcrypt is > available and/or required. > > I see that tests/tcpflood.c has > > #ifdef ENABLE_GNUTLS > # include <gnutls/gnutls.h> > # if GNUTLS_VERSION_NUMBER <= 0x020b00 > # include <gcrypt.h> > GCRY_THREAD_OPTION_PTHREAD_IMPL; > # endif > #endif > > > Maybe it would be simpler to just require a recent enough version of gnutls?
Also, other users of gnutls, e.g. runtime/nsd_gtls.c, also have similar includes #include <gnutls/gnutls.h> #include <gnutls/x509.h> #if GNUTLS_VERSION_NUMBER <= 0x020b00 # include <gcrypt.h> #endif yet, there is no explicit linking against -lgcrypt: if ENABLE_GNUTLS pkglib_LTLIBRARIES += lmnsd_gtls.la lmnsd_gtls_la_SOURCES = nsd_gtls.c nsd_gtls.h nsdsel_gtls.c nsdsel_gtls.h lmnsd_gtls_la_CPPFLAGS = $(PTHREADS_CFLAGS) $(RSRT_CFLAGS) $(GNUTLS_CFLAGS) lmnsd_gtls_la_LDFLAGS = -module -avoid-version lmnsd_gtls_la_LIBADD = $(GNUTLS_LIBS) endif Rainer, why was the explicit "tcpflood_LDADD += -lgcrypt" needed in case of tcpflood but e.g. not for lmnsd_gtls.la? -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? _______________________________________________ rsyslog mailing list http://lists.adiscon.net/mailman/listinfo/rsyslog http://www.rsyslog.com/professional-services/ What's up with rsyslog? Follow https://twitter.com/rgerhards NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
