On 09/01/15 18:18, Rainer Gerhards wrote:
2015-09-01 15:37 GMT+02:00 Tomas Heinrich <[email protected]>:
I think I'll merge it as-is, but we need to keep an eye on it.
OK.
So the idea came up to automatically create core dumps and initiate
valgrind, and it looked pretty well in the beginning. Later,
unforutnately, some issues came up. For example, travis has a 4MB
output size limit, and running the debug output often got us into
problems. Also, in manual development I really don't want that
auto-debug, because it interferes with my development. That's why I
disabled most. But it is a nice feature, we just need better
customization. For example, turn it off when manually working with it
(via configure switch, I think). Also, conditionally (configure?)
enable debug output -- so we can disable it on travis, but enable it
on buildbot where we do not have the size issue. Just to get you the
idea.
Ack. I think more customizability (through env variables?) would be
desirable. A lot of things are hardcoded right now and files get
overwritten which makes post-mortem analysis hard.
So, it looks like the set of randomly failing tests boils down to
valgrind tests + queue-persist.sh.
I have a question regarding queue-persist.sh:
There's an occasional loss of precisely one message during shutdown,
which makes the test fail. Yet, there's this setting in the config file:
$MainMsgQueueTimeoutShutdown 1
Is the message loss in this scenario a bug, or is it expected and the
timeout should be higher / sec-check should tolerate the loss?
During debugging, I came across this line:
*.* :omtesting:sleep 0 1000
There's a bug in omtesting (PR filed[0]) that makes its second argument
to 'sleep' 1000 times smaller than described. Luckily, there are only
two tests, queue-persist.sh and daqueue-persist.sh, using the
microseconds parameter of omtesting.
What I can't tell is whether the above config line assumes the right
units or not..?
HTH,
Tomas
[0] https://github.com/rsyslog/rsyslog/pull/510
_______________________________________________
rsyslog mailing list
http://lists.adiscon.net/mailman/listinfo/rsyslog
http://www.rsyslog.com/professional-services/
What's up with rsyslog? Follow https://twitter.com/rgerhards
NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of
sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE
THAT.
