Makes sense. I'll link the PR here once done.
-- Regards, Janmejay PS: Please blame the typos in this mail on my phone's uncivilized soft keyboard sporting it's not-so-smart-assist technology. On Feb 10, 2016 10:24 AM, "David Lang" <[email protected]> wrote: > the lookup is a function, no question. It was the reload that prompted the > action() question. But your comments on how so many things that are > standard options for actions (queues, etc) make no sense for this and so a > new statement type is much cleaner than either disabling, or interacting > with all those standard things. > > we do have a handful of other non-action/input/module statements. The > parser and global declarations are examples. the only thing that is unique > in table lookups is the ability to trigger the reload based on runtime > logic. > > David Lang > > On Wed, 10 Feb 2016, singh.janmejay wrote: > > Putting it next to functions makes sense. I'll start working on it today. >> >> I thought about it while implementing it. I felt action will be rather >> confusing for this. >> >> It is easier to think of it as a function to lookup, and supporting >> statements to declare,find and load-up on-disk definition, or to reload it >> etc. >> >> Action has controls to build a high throughput egress port with >> configurable formatting (like tuneable queue, parallel processing in >> worker >> pool, safety valve to discard low priority messages, template etc) which >> are not relevant for reload control. >> >> So I feel it's simpler to understand and use as a statement. >> >> -- >> Regards, >> Janmejay >> >> PS: Please blame the typos in this mail on my phone's uncivilized soft >> keyboard sporting it's not-so-smart-assist technology. >> >> On Feb 10, 2016 3:41 AM, "David Lang" <[email protected]> wrote: >> >> My thinking is that the main use is in looking things up, where it is a >>> function and goes everywhere that any of the other functions can go. >>> >>> The action to (re)load the table is a supporting thing, for most people >>> done only at startup. >>> >>> As a (probably) silly thought, should the table (re)load be an action() >>> clause as opposed to a different type of statement? the initial >>> lookup-table writeup was done a long time ago, before action() became a >>> significant part of the config languange. >>> >>> David Lang >>> >>> On Tue, 9 Feb 2016, singh.janmejay wrote: >>> >>> I guess everyone is OK with putting it in as a function and linking out >>> to >>> >>>> details. >>>> >>>> -- >>>> Regards, >>>> Janmejay >>>> >>>> PS: Please blame the typos in this mail on my phone's uncivilized soft >>>> keyboard sporting it's not-so-smart-assist technology. >>>> >>>> On Feb 8, 2016 7:50 PM, "singh.janmejay" <[email protected]> >>>> wrote: >>>> >>>> Well, they don't really fit the definition of functions. Functions in >>>> >>>>> our case are expressions, these are a mix of expression (usage) and >>>>> statement (declaration) and in case of lookup-table it involves an >>>>> out-of-band data-file too. >>>>> >>>>> We can document the usage part of it under functions and then add link >>>>> to a page that talks about the declaration (and explains how it works >>>>> etc). >>>>> >>>>> On Mon, Feb 8, 2016 at 5:15 PM, David Lang <[email protected]> wrote: >>>>> >>>>> On Mon, 8 Feb 2016, singh.janmejay wrote: >>>>>> >>>>>> Does it go parallel to basic_structure or action etc? >>>>>> >>>>>>> >>>>>>> And where all should we link it from? >>>>>>> >>>>>>> >>>>>> >>>>>> I would expect it under functions, I don't know if they need >>>>>> additional >>>>>> links as well. >>>>>> >>>>>> David Lang >>>>>> _______________________________________________ >>>>>> rsyslog mailing list >>>>>> http://lists.adiscon.net/mailman/listinfo/rsyslog >>>>>> http://www.rsyslog.com/professional-services/ >>>>>> What's up with rsyslog? Follow https://twitter.com/rgerhards >>>>>> NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a >>>>>> myriad >>>>>> >>>>>> of >>>>> >>>>> sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you >>>>>> DON'T >>>>>> LIKE THAT. >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Regards, >>>>> Janmejay >>>>> http://codehunk.wordpress.com >>>>> >>>>> _______________________________________________ >>>>> >>>> rsyslog mailing list >>>> http://lists.adiscon.net/mailman/listinfo/rsyslog >>>> http://www.rsyslog.com/professional-services/ >>>> What's up with rsyslog? Follow https://twitter.com/rgerhards >>>> NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad >>>> of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you >>>> DON'T LIKE THAT. >>>> >>>> _______________________________________________ >>>> >>> rsyslog mailing list >>> http://lists.adiscon.net/mailman/listinfo/rsyslog >>> http://www.rsyslog.com/professional-services/ >>> What's up with rsyslog? Follow https://twitter.com/rgerhards >>> NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad >>> of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you >>> DON'T LIKE THAT. >>> >>> _______________________________________________ >> rsyslog mailing list >> http://lists.adiscon.net/mailman/listinfo/rsyslog >> http://www.rsyslog.com/professional-services/ >> What's up with rsyslog? Follow https://twitter.com/rgerhards >> NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad >> of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you >> DON'T LIKE THAT. >> >> _______________________________________________ > rsyslog mailing list > http://lists.adiscon.net/mailman/listinfo/rsyslog > http://www.rsyslog.com/professional-services/ > What's up with rsyslog? Follow https://twitter.com/rgerhards > NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad > of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you > DON'T LIKE THAT. > _______________________________________________ rsyslog mailing list http://lists.adiscon.net/mailman/listinfo/rsyslog http://www.rsyslog.com/professional-services/ What's up with rsyslog? Follow https://twitter.com/rgerhards NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
