On Feb 12, 2009, at 3:19 PM, Jo Rhett wrote: >> On Feb 12, 2009, at 2:43 PM, Jo Rhett wrote: >>> This patch is adapted from something Ian posted for 3.6.4 adapted >>> for 3.8.2. Jesse, please consider adopting this for the mainline as >>> it is a popular question and this patch allows the person to >>> override the default. > > On Feb 12, 2009, at 12:12 PM, Kevin Falcone wrote: >> Since 3.8 added user level preferences, this really looks like >> something which is >> better handled as a user preference. RT::Config has docs about >> adding items >> to %META and marking them as user overridable. It would also want >> some >> changes and docs for RT_Config.pm because you could set a global >> default >> (default would be 0) > > Are you saying that you guys will implement it that way for a later > version? Or is this a request for a patch to implement these things? >
That was a suggestion of how to make the patch better and more compatible with 3.8 I wouldn't apply any patch that adds two new Config variables without documenting them and adding defaults to the shipped config file. -kevin _______________________________________________ http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users Community help: http://wiki.bestpractical.com Commercial support: [email protected] Discover RT's hidden secrets with RT Essentials from O'Reilly Media. Buy a copy at http://rtbook.bestpractical.com
