On 21.06.2016 23:48, Rob Herring wrote:
> On Tue, Jun 21, 2016 at 08:57:18AM +0200, Dirk Behme wrote:
>> From: Oleksij Rempel <[email protected]>
>>
>> ... and Epson RX8900 real time clock
>>
>> Signed-off-by: Oleksij Rempel <[email protected]>
>> Cc: [email protected]
>> ---
>>  .../devicetree/bindings/rtc/epson,rx8900.txt        | 21 
>> +++++++++++++++++++++
>>  1 file changed, 21 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/rtc/epson,rx8900.txt
>>
>> diff --git a/Documentation/devicetree/bindings/rtc/epson,rx8900.txt 
>> b/Documentation/devicetree/bindings/rtc/epson,rx8900.txt
>> new file mode 100644
>> index 0000000..51959de
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/rtc/epson,rx8900.txt
>> @@ -0,0 +1,21 @@
>> +Real Time Clock driver for:
>> +  - Epson RX8900
>> +  - Micro Crystal rv8803
>> +
>> +Required properties:
>> +- compatible: should be: "mc,rv8803" or "epson,rx8900"
>> +- reg : the I2C address of the device for I2C
>> +
>> +Optional properties:
>> +- epson,vdetoff : Disable Voltage Detector. Should be set if no
>> +  backup battery is used.
> 
> set to no? Looks like a boolean to me.
> 
> How about epson,vdet-disable to be consistent.
> 
>> +- trickle-diode-disable : Disable internal trickle charger diode
> 
> boolean?
> 
> Needs a vendor prefix.

This is common name used by many rtc driver without vendor prefix.

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups 
"rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to