On 02/07/2016 at 17:28:07 +0200, Uwe Kleine-König wrote : > Hello, > > this is v2 of the series fixing https://bugs.debian.org/794266. > > The only change compared to (implicit) v1 is that reading out a disabled > alarm is fixed. When the alarm is disabled the respective register is > shadowed with the result is that the reported alarm time is 45:85:0 > because both hour and minute byte are read as 0xff and bcd2bin(0x3f) and > bcd2bin(0x7f) are 45 and 85 respectively. > > The new behaviour is to only set .enabled = 0 and return. Not 100% sure > this is the right thing, though. The only alternative is to enable alarm > and read out a time, but that might have the side effect to trigger an > unwanted alarm, so I didn't chose this way. > > Best regards > Uwe > > Uwe Kleine-König (5): > rtc: s35390a: fix reading out alarm > rtc: s35390a: implement reset routine as suggested by the reference > rtc: s35390a: improve irq handling > rtc: s35390a: improve two comments in .set_alarm > rtc: fix a typo and reduce three empty lines to one > > drivers/rtc/interface.c | 4 +- > drivers/rtc/rtc-s35390a.c | 157 > +++++++++++++++++++++++++++++++++++----------- > 2 files changed, 120 insertions(+), 41 deletions(-) >
All applied, thanks! I added a quick commit message in 4/5. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
