Hello Amelie Delaunay,
The patch 4e64350f42e2: "rtc: add STM32 RTC driver" from Jan 11,
2017, leads to the following static checker warning:
drivers/rtc/rtc-stm32.c:514 stm32_rtc_init()
warn: always true condition '(pred_a >= 0) => (0-u32max >= 0)'
drivers/rtc/rtc-stm32.c
499 static int stm32_rtc_init(struct platform_device *pdev,
500 struct stm32_rtc *rtc)
501 {
502 unsigned int prer, pred_a, pred_s, pred_a_max, pred_s_max, cr;
503 unsigned int rate;
504 int ret = 0;
505
506 rate = clk_get_rate(rtc->ck_rtc);
507
508 /* Find prediv_a and prediv_s to obtain the 1Hz calendar clock
*/
509 pred_a_max = STM32_RTC_PRER_PRED_A >>
STM32_RTC_PRER_PRED_A_SHIFT;
510 pred_s_max = STM32_RTC_PRER_PRED_S >>
STM32_RTC_PRER_PRED_S_SHIFT;
511
512 for (pred_a = pred_a_max; pred_a >= 0; pred_a--) {
^^^^^^^^^^^
We should probably make pred_a, pred_s, pred_a_max and pred_s_max
signed.
513 pred_s = (rate / (pred_a + 1)) - 1;
514
515 if (((pred_s + 1) * (pred_a + 1)) == rate)
516 break;
517 }
518
regards,
dan carpenter
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups
"rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
