Hi Sean,
The mailing list address changed, can you resend there. Also, please
copy the CCF maintainers.
A quick comment below:
On 31/07/2017 at 15:30:13 +0200, Sean Nyekjaer wrote:
> - ret = ds3231_clks_register(ds1307);
> if (ret) {
> dev_warn(ds1307->dev, "unable to register clock device %d\n",
> ret);
> @@ -1545,6 +1708,11 @@ static int ds1307_probe(struct i2c_client *client,
> }
> break;
> case ds_1308:
> + /* disable sqw when driven from battery backup */
> + if (ds1307->regs[DS1307_REG_CONTROL] & DS1308_BIT_BBCLK)
> + i2c_smbus_write_byte_data(client, DS1307_REG_CONTROL,
> + ds1307->regs[DS1307_REG_CONTROL]
> + & ~DS1308_BIT_BBCLK);
That should not be needed, the CCF will disable any unused clock.
> case ds_1338:
> /* clock halted? turn it on, so clock can tick. */
> if (tmp & DS1307_BIT_CH)
> --
> 2.13.3
>
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups
"rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to rtc-linux+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
