2013/4/16 Joel Sherrill <[email protected]>:
> On 4/15/2013 2:20 PM, Andrei Mozzhuhin wrote:
>>
>> Hi,
>> Send patch with improvements as Sebastian Huber suggest in
>> https://www.rtems.org/bugzilla/show_bug.cgi?id=2114.
>
> My quick comments while trying to see what happened in Boston. :(
>
> + Don't use tabs in source files. Use spaces for indentation.
> Standard style is two spaces.
> + doc/shell/file.t needs an entry for df.
>
> Not your issue.. but I was surprised to see that there is no
> group of "common disk commands" like networking has.
>
> Thanks. Please swing at these and update the PR.
>
> --
> Joel Sherrill, Ph.D.             Director of Research & Development
> [email protected]        On-Line Applications Research
> Ask me about RTEMS: a free RTOS  Huntsville AL 35805
> Support Available                (256) 722-9985
>

Updated patch.

Attachment: dosfs-statvfs.patch
Description: Binary data

_______________________________________________
rtems-devel mailing list
[email protected]
http://www.rtems.org/mailman/listinfo/rtems-devel

Reply via email to