On 05/31/2013 04:47 PM, Gedare Bloom wrote:
On Fri, May 31, 2013 at 9:42 AM, Ralf Kirchner
<[email protected]> wrote:
[...]
>@@ -25,6 +28,170 @@
> extern "C" {
> #endif
>
>+typedef struct rtems_dosfs_convert_control rtems_dosfs_convert_control;
>+
I think it is usual to put the struct definition before the function
prototypes in header files. I don't know if we have any rule about it
though.
Its the first declaration in the file, so it is before the function prototypes.
>@@ -131,6 +309,9 @@ int msdos_format (
>
> /** @} */
>
>+int rtems_dosfs_initialize(rtems_filesystem_mount_table_entry_t *mt_entry,
>+ const void *data);
>+
Can you give doxygen for this function now too? I know it did not have
it, but it might be helpful.
Its explicitly outside of the Doxygen group, because this function is not part
of the public interface.
[...]
>+
>+ rtems_dosfs_convert_control *converter;
> } msdos_fs_info_t;
>
Please add a comment about the converter field.
[...]
Why no doxygen comments for these new functions?
[...]
All this stuff is not part of the public interface.
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : [email protected]
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
_______________________________________________
rtems-devel mailing list
[email protected]
http://www.rtems.org/mailman/listinfo/rtems-devel
