James, Thanks. I will check-in if no complaints. Ping me on Thursday if it hasn't been done. -Gedare
On Mon, Mar 24, 2014 at 5:35 AM, James Fitzsimons <james.fitzsim...@gmail.com> wrote: > Hi Gedare, > > I've just submitted a revised patch, I hope it all looks ok now. > > This new patch includes the changes from both the patches I previously > submitted - I hope that isn't a problem? > > Cheers, > James > > > On 20 March 2014 09:06, Gedare Bloom <ged...@rtems.org> wrote: >> >> On Wed, Mar 19, 2014 at 3:11 PM, James Fitzsimons >> <james.fitzsim...@gmail.com> wrote: >> > Hi Gedare, >> > >> > On 20 March 2014 04:48, Gedare Bloom <ged...@rtems.org> wrote: >> >> >> >> Hi James, >> >> >> >> Thanks for the patches! I have a couple of comments. >> >> >> >> First, the commit message for this patch should be divided into two >> >> pieces, a short message on the first line, and then a blank line, and >> >> then a longer detailed explanation. This way, the email subject and >> >> the log will be much easier to read. >> > >> > >> > Can do - that was my first attempt at using git send-email and it didn't >> > turn out quite how I expected! >> > >> >> >> >> Comments about the patch in particular are inline below. Most of these >> >> are style nits that are advised but not required. We don't normally >> >> apply the same rigor to BSPs as to the rest of RTEMS, but appreciate >> >> if you do. :) >> > >> > >> > Of course, no problem. I should have checked for a style guide before I >> > submitted my patch. >> > >> > I'll make the appropriate revisions and submit a revised patch in a few >> > days >> > as I'm about to head off for a short break. >> > >> Thanks. >> Gedare >> >> > Cheers, >> > James >> > > > _______________________________________________ rtems-devel mailing list rtems-devel@rtems.org http://www.rtems.org/mailman/listinfo/rtems-devel
