Mahesh,
On Mon, Jul 31, 2017 at 05:17:34PM -0700, Mahesh Jethanandani wrote:
> > My point, unless my very quick glance at the module mislead me, is that you
> > can't configure to use echo mode - if it's supported - in the grouping
> > imported by the IGPs.
>
> In the current model, it is modeled as a separate grouping with its own set
> of parameters. The expectation is that implementations that want to define
> echo mode would use the grouping. Defining the parameters also implicitly
> defines that echo-mode is enabled. Are you saying that using the echo
> grouping is not enough?
Minimally, I'm saying the IGP use is not pulling in the echo grouping either
directly or indirectly.
> But I do think that the parameters needs to be further protected by an
> if-feature statement that says
>
> grouping echo-cfg-parms {
> if-feature echo-mode;
> description
> "BFD grouping for echo config parameters”;
This seems correct.
> > My implementation doesn't support echo, so I don't have any opinion about
> > where configuration of those belongs or not.
>
> With the feature statement, these echo parameters can exist inside of
> client-cfg-parms, instead as a separate grouping and will be included by the
> platform only if the feature is defined. And this would be my preference. Is
> that what folks would also prefer?
>
I'm ambivalent. This depends really on real world behavior.
As we saw from some brief googling yesterday on Cisco IOS/IOS-XR docs, that
implementation doesn't appear to expose echo intervals as a separably
configurable item. It did, however, expose a boolean to disable echo.
This minimally suggests that there should be a "use echo mode" flag.
The remaining homework is to figure out whether we should expose
configuration state for echo directly in this version of the yang.
-- Jeff
