RTGWG and draft authors, I have the following comments and suggestions on draft-ietf-rtgwg-yang-rip-00. A diff can be found on github at:
http://bit.ly/1RhCABx https://github.com/cbowers/outgoing-feedback-on-ietf-drafts-2015/commit/a7c1050e1eb83eb3bf31af074d0fa1f6e0e66867 The most important comments are copied below. 1) I see that the data model defines distribute-list as a way of defining policy for filtering routes. I think it would be useful to include a more complete data model for routing policy, either instead of or in addition to distribute-list. One option is to import draft-ietf-rtgwg-policy-model and use the apply-policy-group in the same way that draft-ietf-isis-yang-isis-cfg uses it. ******** 2)I think it would make sense to incorporate draft-ietf-bfd-yang in a similar manner to how draft-ietf-ospf-yang and draft-ietf-isis-yang-isis-cfg incorporate it. ************ 3) It does not seem to me that all of the route attributes under the rip->ipv4->routes operational state really belong in this RIP data model. For example, the need-flash and need-download-to-rib attributes do not seem to be RIP specific. If they apply to route entries for other protocols then perhaps they should be put in a separate yang module. Regardless of where they end up, they need to be more clearly defined than the existing definitions in the model. I think many of the route attributes defined here should be removed from this RIP data model. The same comment applies to flash-update-threshold and next-flash-update. ******** 4) The current description of rpc clear-rip-route says that it: "Clears RIP routes from the IP routing table and routes redistributed into the RIP protocol for the specified RIP instance or for all RIP instances in the current context." It is not clear how one acccomplishes the clearing of all RIP instances in the current context. Do it use a special keyword like "all" or does it happen when no argument it passed or something else? ******** Thanks, Chris
_______________________________________________ rtgwg mailing list [email protected] https://www.ietf.org/mailman/listinfo/rtgwg
