Hi Radek, On 4/25/17, 10:33 AM, "Radek Krejčí" <[email protected]> wrote:
>Reviewer: Radek Krejčí >Review result: Ready with Nits > >YANG module: > >- add reference to import statements (both imports are from RFC 6021). Ok > >- use IETF boilerplate with contact and description with copyright I’m assuming you mean the 6087BIS boiler plate? If not, please provide a link. > >- cleanup unnecessary comments (such as "address-family" before the >address-family identity, in general those starting with // in typedefs >section) Ok > >- keep blank lines before and _after_ section comments (/*** ***/) to >be consistent with other ietf-*-types documents Ok > >- timer-multiplier - think about renaming this type. According to the >description, the value should be interpreted as a kind of limit or >threshold, multiplier is not commonly understood as kind of >restriction/limitation, but maybe this is just my personal feeling, >handle this as an input from a reader, not a YANG doctor. We declined this. Those familiar with BFD and other routing protocols which may use the type will not be confused. > >draft: > >- section 7.1 Normative references MUST contain references to all the >imported modules, so you are missing references to RFC 6021. You also >SHOULD/MAY add the references to the documents referenced in the >module (such as RFC 4360 and others) to the appropriate Reference >section in the draft. Will look for additional required references. We don’t want to attempt to add references to every protocol which may use the types. These are meant to be generic routing types. Thanks, Acee > > >Radek > _______________________________________________ rtgwg mailing list [email protected] https://www.ietf.org/mailman/listinfo/rtgwg
