On Wed, Jun 20, 2012 at 1:55 AM, David Moreau Simard <[email protected]> wrote:
> etc/RT_SiteConfig.pm:
> Set(@RTIR_IPv4_range_preference, qw (
>        192.168.0.0/16
>        127.0.0.0/24
>        )
> );

Feature is good to have, but to make it into RTIR core it should be
IPv6 aware. I don't see
much need in additional module, but it's ok. Code needs cleanup. It's
complex already and you
change makes it even more nested. Why don't you put the check into
AddIP method? I think
it belongs there.

-- 
Best regards, Ruslan.
_______________________________________________
Rtir mailing list
[email protected]
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rtir

Reply via email to