Jan Kiszka wrote:
> Andras Garzo wrote:
>> Hi,
>>
>> I've ported BF537-stamp on-chip mac driver to RTNet. It seems, works
>> with Xenomai 3.3.2, RTNet 0.9.9 and uClinux 2007R1. You can find
>> the ported code at http://garzoand.web.elte.hu/rtnetdev-bf537.tgz .
> 
> Wow, cool. You just stole my planned holiday entertainment for the next
> year, but I really don't mind (there will be enough alternatives ;) ).

You know how to make this even cooler? Provide your driver in form of a
patch which also includes build system adoptions. That would make it
easier for me to integrate it into the SVN tree... :->

First comment after a first glance on the code: In
bf537mac_hard_start_xmit, there is no provision to ensure that patching
the time stamp into an outgoing frame and triggering its transmission is
atomic (with respect to IRQ preemptions e.g.).

Jan

Attachment: signature.asc
Description: OpenPGP digital signature

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
RTnet-users mailing list
RTnet-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/rtnet-users

Reply via email to