anju Mary wrote: > Hello everybody, > I got reply for some of my queries.I was told to post > the changes in form of a patch against rtnet.git.But i dont know how to post > in the specified format.
Unified diff (diff -up orig.file modified.file). Or have at look at git, clone rtnet's repository and add your changes as commits. Those can be exported in the required format as well. > Now i am sending my entire driver program with this > mail can anyone check it out and give me feedbacks??????? > thanks in advance.... Uhh, this looks nasty. There is no ts109 in the upstream kernel, and the tsi108 there looks much nicer as it was cleaned up before being merged. The usage of the various Linux spinlock in ts109 make me doubt that the original driver was ever reviewed by the kernel community. Where did you get your version from? Do you have some link to that code? Some more remarks on your changes: - The copyright header only indirectly states that this code is under GPL and it fails to mention the version. - Make sure to use proper locking. rtdm_irq_disable/enable should not be used to disable IRQs for a critical section, rtdm_lock_* comes with proper IRQ-blocking services. - Do no convert a Linux spinlock to an rtdm_lock if it is not used in some critical path. E.g. the stat functions do not belong into this category, the RTnet core call them in normal Linux context. - rtdm_lock_get is not equivalent to spin_lock, the latter implies preemption disabling, the former not. I already commented on the other topics like (non-existent) skb fragmentation. Jan
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev
_______________________________________________ RTnet-users mailing list RTnet-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/rtnet-users
