Well, I compare the received size with an expected size. The rt_e1000 driver
returns the expected size + 4.
The rt_eepro100 and the rt_e1000_new driver are substracting the CRC. If you
like I can send you a patch on release 0.9.12 (I have no knowledge of git).
Frederik
-----Oorspronkelijk bericht-----
Van: Jan Kiszka [mailto:jan.kis...@web.de]
Verzonden: do 17/02/2011 10:00
Aan: Frederik Bayart
CC: rtnet-users@lists.sourceforge.net
Onderwerp: Re: e1000 driver doesn't remove CRC
On 2011-01-19 11:00, Frederik Bayart wrote:
> Hallo,
>
> I noticed that the e1000 driver of rtnet (version 0.9.12, but according to me
> this should also be the case in version 0.9.11) doesn't remove the CRC from
> the payload, although this is done is the original e1000 driver code from the
> linux kernel.
>
> In function e1000_clean_rx_irq, the original code contains the lines below :
>
> /* adjust length to remove Ethernet CRC, this must be
> * done after the TBI_ACCEPT workaround above */
> length -= 4;
>
> These lines are disappeared in the rtnet e1000 driver code, so that the
> packet forwarded to higher layers contains the CRC. Is there any reason for
> that ?
Frankly, I don't remember ATM. Did you notice problems in the higher
layers due to this?
Jan
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
RTnet-users mailing list
RTnet-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/rtnet-users
