Hello,

could I ask somebody to review these packages?:

https://bugzilla.redhat.com/show_bug.cgi?id=1079640  rubygem-json_spec
https://bugzilla.redhat.com/show_bug.cgi?id=1076976  rubygem-settingslogic

They are my first ruby packages, so I'm not sure about some
fedora-review complains:

[!]: Gem should use %gem_install macro.
  - false alarm?

[ ]: Specfile should use macros from rubygem-devel package.
     Note: The specfile doesn't use these macros:
     /usr/share/gems/specifications/settingslogic-2.0.9.gemspec, %
exclude
     /usr/share/gems/cache/settingslogic-2.0.9.gem

gems should require rubygems package
  Note: Requires: rubygems missing in rubygem-settingslogic-doc
  See: http://fedoraproject.org/wiki/Packaging:Ruby#RubyGems
 - there is rubygems R-dep only indirectly from the base package, but it
is probably better to have the direct dependency too? (-doc is using
rubygems directories)

Thank you,
  František

_______________________________________________
ruby-sig mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/ruby-sig

Reply via email to