Dne 25. 09. 23 v 10:17 Vít Ondruch napsal(a):
I don't agree with B.Users are free to install tzinfo-data gem instead, which might or might not give them more freedom. Option B is quick and dirty and with that, we have not really moved anywhere. So I am for A short term and long term we can explore why AS tries to require tzdata.
Reported here: https://github.com/rails/rails/issues/49375 Vít
Vít Dne 25. 09. 23 v 0:35 Mamoru TASAKA napsal(a):Pavel Valena wrote on 2023/09/24 23:53:I agree. I was just thinking of adding it to activesupport. Regards, PavelOkay, thank you! I see that this rubygem-activesupport change (to have Requires: tzdata) cleared out the most of FTBFS I listed below. Looking closely, it is found that * rubygem-jekyll itself tries to use tzinfo directly. I will going to add "BuildRequires (not Requires): tzdata" to jekyll (as it seems it is not always required). MamoruOn Sun, Sep 24, 2023 at 2:10 AM Neal Gompa <ngomp...@gmail.com> wrote:On Sat, Sep 23, 2023 at 7:50 PM Mamoru TASAKA <mtas...@fedoraproject.org>wrote:https://koschei.fedoraproject.org/package/rubygem-timecop?collection=f40Hello, ruby-sig folks: From devel list: Zbigniew Jędrzejewski-Szmek wrote on 2023/09/22 23:01:On Fri, Sep 22, 2023 at 10:43:05AM +0200, Vít Ondruch wrote:https://bugzilla.redhat.com/show_bug.cgi?id=2233281#c3 This probably answers my question. So heads up to others. Dne 22. 09. 23 v 10:39 Vít Ondruch napsal(a):Was this implemented in past days? I am asking because this FTBFS suggest so:Yes. The change was done in rawhide a while ago, but it got pushed toF39only recently, seehttps://bugzilla.redhat.com/show_bug.cgi?id=2233281#c3./usr/share/gems/gems/tzinfo-2.0.6/lib/tzinfo/data_sources/zoneinfo_data_source.rb:252:inZbyszekNow again I tried rebuilding all rubygem- packages, and now due to this tzdata removal changes, the following packages are now additionally FTBFS: rubygem-activemodel-serializers-xml rubygem-globalid rubygem-haml rubygem-importmap-rails rubygem-jekyll rubygem-rails-controller-testing rubygem-sassc-rails rubygem-slim rubygem-sprockets-rails rubygem-timecop rubygem-web-console And all of these seems like:`initialize': None of the paths included in TZInfo::DataSources::ZoneinfoDataSource.search_path are valid zoneinfo directories. (TZInfo::DataSources::ZoneinfoDirectoryNotFound)/usr/share/gems/gems/tzinfo-2.0.6/lib/tzinfo/data_source.rb:157:in `new'fromfrom/usr/share/gems/gems/tzinfo-2.0.6/lib/tzinfo/data_source.rb:157:in `create_default_data_source'/usr/share/gems/gems/tzinfo-2.0.6/lib/tzinfo/data_source.rb:55:in `block infromget'from/usr/share/gems/gems/tzinfo-2.0.6/lib/tzinfo/data_source.rb:54:in `synchronize'/usr/share/gems/gems/tzinfo-2.0.6/lib/tzinfo/data_source.rb:54:in `get'from/usr/share/gems/gems/activesupport-7.0.8/lib/active_support/railtie.rb:88:infrom`block in <class:Railtie>'from/usr/share/gems/gems/railties-7.0.8/lib/rails/initializable.rb:32:in `instance_exec'/usr/share/gems/gems/railties-7.0.8/lib/rails/initializable.rb:32:in `run'from/usr/share/gems/gems/railties-7.0.8/lib/rails/initializable.rb:61:in `blockfromin run_initializers'from /usr/share/ruby/tsort.rb:231:in `block in tsort_each' from /usr/share/ruby/tsort.rb:353:in `block (2 levels) ineach_strongly_connected_component'from /usr/share/ruby/tsort.rb:434:in`each_strongly_connected_component_from'from /usr/share/ruby/tsort.rb:352:in `block ineach_strongly_connected_component'from /usr/share/ruby/tsort.rb:350:in `each' from /usr/share/ruby/tsort.rb:350:in `call' from /usr/share/ruby/tsort.rb:350:in`each_strongly_connected_component'from /usr/share/ruby/tsort.rb:229:in `tsort_each' from /usr/share/ruby/tsort.rb:208:in `tsort_each' from/usr/share/gems/gems/railties-7.0.8/lib/rails/initializable.rb:60:in `run_initializers'from/usr/share/gems/gems/railties-7.0.8/lib/rails/application.rb:372:in `initialize!'..... So initializer of rails tries to initialize tzdata, and if it is notfound exception is raised:https://github.com/rails/rails/blob/fc734f28e65ef8829a1a939ee6702c1f349a1d5a/activesupport/lib/active_support/railtie.rb#L87-L91The related code is:So what is the proper fix for this? A. Make every package above have "BuildRequires: tzdata" B. Make rubygem-tzinfo or rubygem-activesupport have "Requires (notRecommends) tzdata"C. Or ask rubygem-activesupport upstream to make the code work even iftzdata is absentMy current thought is that as currently RoR code explicitly requests tohave tzdata installed,B. is the best option.I agree that Option B is the best option. -- 真実はいつも一つ！/ Always, there's only one truth! _______________________________________________ ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org To unsubscribe send an email to ruby-sig-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelinesList Archives:https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraproject.orgDo not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue_______________________________________________ ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org To unsubscribe send an email to ruby-sig-le...@lists.fedoraproject.orgFedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelinesList Archives: https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue_______________________________________________ ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org To unsubscribe send an email to ruby-sig-le...@lists.fedoraproject.orgFedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelinesList Archives: https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
OpenPGP_signature.asc
Description: OpenPGP digital signature
_______________________________________________ ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org To unsubscribe send an email to ruby-sig-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
