Re: Updating json 2.7.5 on F42

[Vít Ondruch via ruby-sig]

Hi Mamoru,





https://github.com/ruby/json/issues/277

https://github.com/ruby/json/pull/567

https://github.com/ruby/json/commit/c57d33ec39344f7a6ae2786b8ac36892a51b03fe


So you'd likely want to check the license more carefully this time.


Vít


Dne 30. 10. 24 v 16:10 Mamoru TASAKA via ruby-sig napsal(a):

On related note, not sure if you have noticed, but there were some code updates related to licenses:

Hello, all:

rubygem-json 2.7.5 is released and I am going to update
rawhide (F42) rubygem-json to this version.
(because the upcoming ruby 3.4.0 will anyway have this or
 higher version of rubygem-json.)


Mass rebuild for this version of rubygem-json shows that
the following pkg(s) will newly FTBFS:

rubygem-activesupport

https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-6/build/8189534/

  1) Failure:
TestJSONEncoding#test_hash_keys_encoding [test/json/encoding_test.rb:59]:
--- expected
+++ actual
@@ -1 +1 @@
-"{\"\\u003c\\u003e\":\"\\u003c\\u003e\"}"
+"{\"<>\":\"\\u003c\\u003e\"}"

git bisect shows that the above failure begins with:

https://github.com/ruby/json/commit/e125072130229e54a651f7b11d7d5a782ae7fb65

So git commit message shows:

'''
Directly use `generate_json_string` for object keys
instead of `generate_json`.

Since the object key is already confirmed to be a string, using a
generic dispatch function brings an unnecessary overhead.
'''

But as the side effect, now object key value is not going to be escaped.
I am not sure if this is desired or not.

Regards,
Mamoru

OpenPGP_signature.asc
Description: OpenPGP digital signature

-- 
_______________________________________________
ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org
To unsubscribe send an email to ruby-sig-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue