is this happening every time? possibly some non-mp3 files in the dir? also, Dir.foreach does not give the full path so may have to append the path,
On Fri, Dec 7, 2012 at 8:14 PM, peteV <[email protected]> wrote: > On 12/07/2012 07:54 PM, Chris Hulan wrote: > > here's how i'd do it: https://gist.github.com/4237869 > > > On Fri, Dec 7, 2012 at 7:45 PM, Chris Hulan <[email protected]> wrote: > >> I think the error is due to a missing 'end' >> you have 2 'do' blocks but only 1 'end' >> >> Note 'file' is a string so no need to '.to_s' nor "#{..}" >> >> >> On Fri, Dec 7, 2012 at 6:28 PM, peteV <[email protected]> wrote: >> >>> On 12/07/2012 05:17 PM, peteV wrote: >>> >>>> >>>> >>>> File.rename ( "#{file}","#{tag.title}-#{tag.artist}.mp3") >>>> >>>> end # File is automatically closed at block end >>>> >>>> ------------------------------------------------------------------------------ >>>> >>>> here is the error dump >>>> ./taglibex.rb:15: syntax error, unexpected ',', expecting ')' >>>> File.rename ( "#{file}","#{tag.title}-#{tag.artist}.mp3") >>>> ^ >>>> ./taglibex.rb:15: syntax error, unexpected ')', expecting keyword_end >>>> >>>> >>>> >>>> of course the error dump needed to contain the "#{tag.title}" :-[ >>> I had copied a previous error dump by mistake from the cmd line >>> >>> >>> >> > thanks guys that got me passed the syntax error. > > hey Chris, these are the errors I get now using your code solution > > TagLib: FileRef::tag() - Called without a valid file. > TagLib: FileRef::tag() - Called without a valid file. > TagLib: FileRef::audioProperties() - Called without a valid file. > > > -- You received this message because you are subscribed to the Google Groups ruby-talk-google group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at https://groups.google.com/d/forum/ruby-talk-google?hl=en
