https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222872
--- Comment #18 from John Hein <jcfyecr...@liamekaens.com> --- (In reply to Koichiro Iwao from comment #17) > Are any other QA tests required? No required QA tests that I know of. It is worthwhile to test and confirm that this change works with both older, non-compliant, /bin/sh and compliant shell implementations (and mention this in the commit message). For what it's worth, I have tested this and confirmed this is true on older, now EOL, versions of FreeBSD (back to 4.x) through the the latest FreeBSD /bin/sh. But feel free to independently do some testing. Unrelated to this change, portclippy suggests different ordering of elements in the Makefile. While here, a separate commit could be made to address those (separate to keep formatting changes from distracting from the meaningful on-topic change). But that's not at all required. -- You are receiving this mail because: You are on the CC list for the bug.
