On Fri, 23 Dec 2005, David Corbin defenestrated me: > On Friday 23 December 2005 08:48 pm, David Corbin wrote:> > > Thomas' positioning fixes look much better, though I've found a problem > > with how we're handling unclosed quotes that's now showing up. > > > > OK. It turns out the 'unclosed quote' is reporting an end offset one > character longer than the file actually is. This is causing Eclipse to treat > the error marker 'poorly'. The right solution, of course, is to correct the > parser. So we'll have to wait for Tom to get back to get it correct.
Oops. I have this partially corrected and I am plugging away.. It is a slightly bigger problem than it appears. I made a pretty fundamental error in offsets. I am reporting endOffset as the index one past the last character of the Node. This is clearly wrong and can be easily seen when the Node is next to EOF (as in producing an offset longer than the file). The unclosed quote problem is just a manifestation of this behavior. So endoffset should really be the index of the last character for the node. So for example: foo EOF foo a VCallNode should have an endOffset of 2 and not 3. Another example: def foo end EOF Should have 10 (index of 'd' in end) not 11 (one past). I will commit something when I get enough unit tests passing again... -Tom -- + http://www.tc.umn.edu/~enebo +---- mailto:[EMAIL PROTECTED] ----+ | Thomas E Enebo, Protagonist | "Luck favors the prepared | | | mind." -Louis Pasteur | ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ Rubyeclipse-development mailing list Rubyeclipse-development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/rubyeclipse-development
