On Monday 19 June 2006 23:48, Christopher Williams wrote: > We do the selection handling in RubyAbstractEditor for the outline: > org.rubypeople.rdt.internal.ui.rubyeditor.RubyAbstractEditor.setSelectio > n() > We create the positions in RubyScriptSturctureBuilder: > org.rubypeople.rdt.internal.core.RubyScriptStructureBuilder > > I had some hacks in to fix positions before, but I'm not sure where > they are now. If anything they ought to be closest to parsing which > is the structure builder, maybe I managed to catch all the cases in > the setKeywordRange and setTokenRange methods...
Ok, I'll take a look at it tomorrow. > In any case, I know that lack of CommentNodes was causing some off-by- > one position problems before. JRuby's parser would eat up lines with > only comments and carriage returns on it, and our offsets would end > up off by the number of carriage returns eaten. I hope we can fix this too, once the comments are in the AST (should happen in the next few weeks). > BTW, Do you want to be added as an RDT developer so you can directly > apply patches to our codebase and then use svn:externals to keep in > sync? That would be great :-) Although I don't know yet how svn:externals works. I think I have to dig out my subversion book.. Thanks, Mirko
pgprbrnpVmnua.pgp
Description: PGP signature
_______________________________________________ Rubyeclipse-development mailing list Rubyeclipse-development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/rubyeclipse-development
