Hello List,

Found a problem checking the tests for the beta.

First I must apologize for not correctly test this, was too focus on
platform that ignored the other stuff.

I have found what I commented before about creating my own local
mirror for gems. Zlib problems...

It seems that AbstractIndexBuilder#compress was reading the file
'as-is' and not forcing binary mode, like the other places.

The following patch correct this, but raises other issues regarding
OpenURI and proper support of Windows paths.

I'll look further into this.

http://pastie.caboo.se/107249

Again, sorry that I missed these things before RubyGems hit beta. Was
overwhelmed due work.

Regards,

-- 
Luis Lavena
Multimedia systems
-
Leaders are made, they are not born. They are made by hard effort,
which is the price which all of us must pay to achieve any goal that
is worthwhile.
Vince Lombardi
Index: lib/rubygems/indexer/abstract_index_builder.rb
===================================================================
--- lib/rubygems/indexer/abstract_index_builder.rb	(revision 1458)
+++ lib/rubygems/indexer/abstract_index_builder.rb	(working copy)
@@ -46,7 +46,7 @@
 
   # Compress the given file.
   def compress(filename, ext="rz")
-    zipped = zip File.read(filename)
+    zipped = zipped = zip(File.open(filename, 'rb') { |fp| fp.read })
     File.open "#{filename}.#{ext}", "wb" do |file|
       file.write zipped
     end
_______________________________________________
Rubygems-developers mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/rubygems-developers

Reply via email to