On Thu, Apr 24, 2008 at 10:02 AM, Vladimir Sizikov <[EMAIL PROTECTED]> wrote: > Hi folks, > > There were a couple of bug reports against JRuby recently, related to > rubygems on Windows, and I'd like to double-check with you on them > first. > > The issues are: > JRUBY-2431: Rubygems under JRuby doesn't install BAT executable files > on Windows > http://jira.codehaus.org/browse/JRUBY-2431 > > JRUBY-2432: Rubygems under JRuby detects the ruby executable name > incorrectly on Windows > http://jira.codehaus.org/browse/JRUBY-2432 > > The first issue due to fact that rubygems doesn't detect the Windows > platform on JRuby, since rubygems uses RUBY_PLATFORM, and in JRuby > case the value is "java". > > This also leads to exceptions if --no-wrappers is used. > > The fix is straightforward: in addition to RUBY_PLATFORM, to use > RbConfig's info to detect the platform. > > The second issue is due to fact that RbConfig's ruby_install_name for > JRuby on Windows is jruby.bat (since we don't have the native binary, > only the bat file that starts java), and rubygems adds the "EXEEXT" > value thus producing: jruby.bat.exe > > The fix is simple too: to check if the extension is already present > (and is equal to BAT or EXE), and only add the "EXEEXT" value in case > if no extension is present in ruby_install_name value). > > Any concerns or comments? If that's OK, I'll send out a couple of > patches to resolve these issues. >
Hello Vladimir, I can take a look at those bug if not special requirements are needed to setup JRuby for testing (already have JRE installed). Maybe we need add some tests for these cases into rubygems. > Thanks, > --Vladimir Thanks to you for your time, Regards, -- Luis Lavena Multimedia systems - Human beings, who are almost unique in having the ability to learn from the experience of others, are also remarkable for their apparent disinclination to do so. Douglas Adams _______________________________________________ Rubygems-developers mailing list [email protected] http://rubyforge.org/mailman/listinfo/rubygems-developers
