Hey folks,
I need to send a patch [1], but, I don't think that's quite right yet,
so until I try and grok why the test still pass, I have some
questions...
First of all, I note that gem19 install rake will install rake to
rake19, and so on. This means the above patch is still wrong under
those conditions.
How do I find out the correct prefix from rubygems?
Regarding the above patch, it solves an issue when building the new
eventmachine rake build gem, under conditions that rake is being
invoked from jruby -S gem install gemname. The prior code would invoke
'rake' from the path, which would lead in some configurations to the
MRI install. Whilst rake is pretty common, what we do in the gem is
this:
http://github.com/eventmachine/eventmachine/tree/master/
Rakefile#L38-39 (ruby_platform =~ java)
In order to allow for a common gem, which will build on a number of
ruby platforms:
http://github.com/eventmachine/eventmachine/tree/master/Rakefile#L54-61
Another slight aside, but interesting, is how I went about dealing
with the fact that we don't currently supply args to rake builds:
http://github.com/eventmachine/eventmachine/tree/master/Rakefile#L42-48
Thanks in advance,
James.
[1]
From a009f31f8a21313332359644e36db5f431f8bf6a Mon Sep 17 00:00:00 2001
From: raggi <[EMAIL PROTECTED]>
Date: Tue, 11 Nov 2008 00:30:48 +0000
Subject: [PATCH] Added a fix for rake path search
---
lib/rubygems/ext/rake_builder.rb | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/rubygems/ext/rake_builder.rb b/lib/rubygems/ext/
rake_builder.rb
index 0c64e61..0f5f629 100644
--- a/lib/rubygems/ext/rake_builder.rb
+++ b/lib/rubygems/ext/rake_builder.rb
@@ -15,7 +15,7 @@ class Gem::Ext::RakeBuilder < Gem::Ext::Builder
run cmd, results
end
- cmd = ENV['rake'] || 'rake'
+ cmd = ENV['rake'] || "#{Gem.ruby} -S rake"
cmd += " RUBYARCHDIR=#{dest_path} RUBYLIBDIR=#{dest_path}" # ENV
is frozen
run cmd, results
--
1.5.6.rc3.7.g336d0.dirty
_______________________________________________
Rubygems-developers mailing list
Rubygems-developers@rubyforge.org
http://rubyforge.org/mailman/listinfo/rubygems-developers
