On May 4, 2011, at 16:55 , Luis Lavena wrote: > It is not clear to me if a bugfix should first need to be committed to > master and then backported to 1.8 branch or viceversa? > > Indexer is broken due a typo on Windows, that single typo solved all > the test_gem_indexer tests: > > C:\Users\Luis\Projects\oss\rubygems>git diff > diff --git a/lib/rubygems/indexer.rb b/lib/rubygems/indexer.rb > index db823d7..23c0167 100644 > --- a/lib/rubygems/indexer.rb > +++ b/lib/rubygems/indexer.rb > @@ -80,7 +80,7 @@ class Gem::Indexer > @master_index = File.join @directory, 'yaml' > @marshal_index = File.join @directory, marshal_name > > - @quick_dir = File.join, @directory, 'quick' > + @quick_dir = File.join @directory, 'quick' > @quick_marshal_dir = File.join @quick_dir, marshal_name > @quick_marshal_dir_base = File.join "quick", marshal_name # FIX: UGH
God our tests are lame... someday... This was discussed in IRC but I'll repeat it here: Please commit all fixes to master and we'll cut 1.8.1 from there. New features (erikh just added better output to gem list) should go there too, but for a couple days after a dot-oh should either not be pushed or should go to a feature branch. > Still remains another test to fix which seems invalid generation of > gem metadata, will investigate. thanks! _______________________________________________ Rubygems-developers mailing list http://rubyforge.org/projects/rubygems Rubygems-developers@rubyforge.org http://rubyforge.org/mailman/listinfo/rubygems-developers
