Glad the patch was finally accepted! Thanks to nzkoz for overseeing it and to minam for making it duck-safe.
On Jan 12, 2:00 am, "eventualbuddha" <[EMAIL PROTECTED]> wrote:
Patch has been updated with Duration directly under ActiveSupport, plus a test for Duration#inspect and some documentation fixes. Let me know if anything else needs to be done. On Jan 7, 2:35 pm, "eventualbuddha" <[EMAIL PROTECTED]> wrote: > > Nice work, further thoughts. Perhaps Duration should sit in > > ActiveSupport:: rather than hidden away in the core extensions?Sure. I just put it there since I didn't envision people using it > directly and it was just simpler to write it that way. > > Why do you use the blankslate?I use blankslate in order to maintain backward compatibility with > existing applications that may depend on the fact that 1.hour returns a > Numeric type. So Duration acts like a Numeric when it is treated as one > (for example, when using < and >). This compatibility is not actually > required for any of my applications, but I figured that it would be for > others. > Unless you have any other suggestions, I'll create another patch with > duration living directly under ActiveSupport. Would you suggest giving > it its own file?
--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
