Anthony Eden wrote: > On 1/24/07, Justin Forder <[EMAIL PROTECTED]> wrote: >> You are right to point out that variations in environment can cause a >> test to fail for the creator of a ticket, but succeed when tested by a >> Rails committer. >> >> But the situation you are concerned about seems to be when the ticket >> creator hasn't given a failing (for him/her) test. You are proposing >> that the Rails committer who wants to close a ticket (i) interprets the >> reported problem in terms of a test, (ii) writes the test, and (iii) >> demonstrates that, in some 'standard' environment, the test passes. >> >> In other words, you are proposing that Rails is presumed guilty until >> proved innocent, and asking the committers to act as the lawyers for the >> defendant. >> >> The number of Rails users is in the tens or hundreds of thousands, with >> a wide variety of levels of skill and experience. You can see from >> reading the mailing list how often people raise 'problems' that turn out >> to be the result of their own error or misunderstanding. >> >> The number of committers is small, and they are highly skilled. In the >> circumstances, the committers *must* be able to close tickets without >> spending a lot of time explaining why, and the burden must then fall on >> the ticket creator to justify reopening the ticket. Anything else >> doesn't make economic sense. > > I am actually more concerned with people who are not committers > closing tickets. One of the privileges of being a committer on a > project is that you have gained enough trust to warrent the right to > close tickets. Having said that, I still believe that *anyone* who > wants to close a ticket due to lack of tests should at least mark it > as untested and then close it. This is the common practice of the > Rails committers and is even documented in the needy report. By > marking it untested it appears in the needy report and can be followed > up on by others when time permits. Marking it as worksforme or wontfix > just seems wrong to me. > > Anyhow, we can discuss this until we're blue in the face. At the end > of the day what matters is how we behave. To that end *I* will > continue to follow my own advice as to how to handle tickets for > Rails, and I encourage others to do the same, if for no other reason > than to contribute more test coverage to, and to inspire more > confidence in the stability of, the best darn web framework out there.
Thanks, Anthony - that makes sense to me. regards Justin --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
