On Jan 19, 2007, at 3:22 PM, Benjamin Curtis wrote:

>
> On Jan 19, 2007, at 12:50 PM, Michael Koziarski wrote:
>
>>
>>> Currently create_table accepts a :primary_key => 'field_name'
>>> argument, so the dumper could use that.
>>
>> Sounds good, I didn't realise that was there already :).
>>
>>> Should the model generator
>>> also be changed to produce a migration in that format?
>>
>> Give it a try and we'll see what the patch looks like.  It's a bit of
>> a rathole really, with all sorts of crazy naming standards we could
>> support, I'm pretty sure fixing the dumper to correctly create the
>> primary keys is going to be a happy middle ground.
>>
>
> I decided to hold off for now on making changes to the model   
> generator's migration.  I'll open another ticket for that if I do it.
>
> I have added a new patch to ticket #7805 that omits the changes to   
> schema_statments.rb.  Now the patch will result in the schema  
> being  dumped with the :primary_key => 'tablename_id' option to  
> create_table  as appropriate.
>

I have opened a new ticket, http://dev.rubyonrails.org/ticket/7367,  
which patches the generator to output the correct fixture and  
migration for non-nil values of  
ActiveRecord::Base.primary_key_prefix_type.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to