On 2/26/07, zdennis <[EMAIL PROTECTED]> wrote: > > This depends on how things are implemented. I think we need to avoid > implicitly encouraging people doing things like: > > class MyAdapter < AbstractAdapter > alias :some_method :some_method_orig > def some_method > .... > end > end > > If we can avoid that then I'll all for it, but if that's how we're > relying on mixins to provide additional functionality I think we can > come up with a better way.
I understand where you're coming from; however: It completely avoids having people go read through AR source to find > out what sanitize_sql and quote_attribute_conditions, etc.. methods > do. Rather then don't have to care about implementation, they can > rather focus on the functionality they want. there just isn't that much code here! It's a handful of methods. Adding this query handler registration scheme is easily more complex than the code it's mean to simplify. That said, I like the ideas you're wrapping *within* these handlers. jeremy --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
