For those of you following the earlier saga of the performance of limited eager loading, I've decided to give up on pursuing my original patch. I received some support on the simplification argument (see my blog if you don't know what I'm talking about), but it doesn't seem like it's worth breaking existing behavior. So I'm moving onto promoting http://dev.rubyonrails.org/ticket/9497 which gathers up the list of tables that are referenced in conditions and joins and uses them to restrict what is actually joined. Although the diff looks a little confusing due a slight refactoring of the methods, in actuality there is less than one line of new code here.
I haven't added a test, because: a) this patch's correctness is largely defined by the fact that it doesn't break other tests which have pretty wide coverage over this area of ActiveRecord. b) I didn't see offhand a great way to verify the removal of the joins. Anyway, if anyone can do a quick review and hopefully garner some +1s I'd love to get this in before 2.0. -- Gabe da Silveira http://darwinweb.net --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
