On 10/1/07, Andrew White <[EMAIL PROTECTED]> wrote:
>
> On 1 Oct 2007, at 03:57, Michael Koziarski wrote:
>
> > 1) Why are there still some hard coded semicolons in the route
> > creation methods?
>
> The routes with semi-colons in are just the deprecated routes - they
> should always be a semi-colon as there wasn't an option before. This
> addresses bitsweat's concern over breaking incoming links - even if
> some switches to 2.0 style routes the 1.2.x routes are still
> recognized. IMO, they should be permanently redirected to the new
> links but I thought that bitsweat wouldn't like that and it's
> straightforward to add a filter to do in ApplicationController.
>
>
> > 2) Shouldn't the seperator default to ; for 1.2.x and / for 2.x?
>
> This so that any new links generated are forward compatible with 2.x.
> Any routes that would've had a semi-colon are added by (1) above so
> defaulting to ; would only add duplicate routes - defaulting to /
> means that out of the box 1.2.4 and above will recognize both 1.2.3
> and 2.0 urls.

ok,  last query,  the docs need to be updated to reference the new
routes, and remove the reference to semicolons.  Apart from that looks
good to go!


-- 
Cheers

Koz

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to