I think we need a real fix for the issue. Requiring inflections to be done about the initializer block is no better than requiring some internal method call. Either way, the developer will have to analyze the issue then find the work-around. I would support some kind of mechanism where the inflector itself is responsible for reloading routes if it is modified. It's a little ugly, but if we throw a test in there it makes a huge potential headache go away.
On 10/5/07, Jon Garvin <[EMAIL PROTECTED]> wrote: > > Michael Koziarski wrote: > > [7369] doesn't include any tests showing that it fixes anything (I thought > that was one of the new rules!? ;-) ), nor do the comments with the revision > give any hints to it's purpose or ticket it closes. I'm not seeing the > benefit and it's definitely going to introduce unnecessary headaches for a > fraction of the Rails community. So, I'm curious what this change was for, > and if it's actually helping anybody. > > > It's a siginificant performance improvement in development mode, I've > noticed it and I'm hugely happy with it :). > > That's good to hear. > > reload isn't a documented > part of the API so I don't think it's that big a deal. reload could > be named something like > reload_unless_routes_dot_rb_hasnt_been_changed, but I don't think > that's justified. > > > No, I agree. > > A one character change for those painting outside the lines doesn't > seem like it's too much to worry about. > > I don't know that I would label those who write their application in > languages other than English as "painting outside the lines" ;-) Nor simply > needing things like a waves_controller, and wanting to be able to call > wave_path(1), instead of "wafe_path(1)" > > Besides, couldn't you just > put the inflections *above* the initializer block? > > > That would be a fantastic solution if it worked, except it results in... > > "uninitialized constant Inflector" > > Any solution that managed to setup the custom inflections before the > routes would make me very happy (and I'd be very willing to work on the > patch once pointed in the right direction). Other ideas? > > -- http://www.5valleys.com/http://www.workingwithrails.com/person/8078 > > > > > -- Gabe da Silveira http://darwinweb.net --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
