Thanks Jeremy! And much appreciated to everyone who looked at it and helped to verify the patches too.
Regarding the Hash#symbolize_keys! in http://dev.rubyonrails.org/ticket/10717, I didn't realize it was (basically) a revert of http://dev.rubyonrails.org/changeset/8333. Does anyone know the rationale for that patch (other than readability and re-using Hash#symbolize_keys)? ReinH perhaps? I know it may not be worth reverting for a minor performance improvement but still, every little bit helps so long as it doesn't sacrifice too much. Cheers, Chu Yeow On Jan 7, 4:52 am, "Jeremy Kemper" <[EMAIL PROTECTED]> wrote: > On 1/6/08, chuyeow <[EMAIL PROTECTED]> wrote: > > > I'm looking for people with time on their hands to help verify a > > couple of patches. Without further ado: > > >http://dev.rubyonrails.org/ticket/10717- Clean up Hash#stringify_keys > > and slight optimization to Hash#symbolize_keys! > >http://dev.rubyonrails.org/ticket/10549- asset_host proc now takes an > > optional request argument (useful for serving assets from SSL-enabled > > pages) > >http://dev.rubyonrails.org/ticket/10726- Refactor Hash.from_xml from > > files with a Decorator, basically replacing evals with a Decorator > > implemented with a module > >http://dev.rubyonrails.org/ticket/6684- allow render :text => false > > and render :text => nil (fix for long-standing bug), already verified > > though > > All applied (10717 partially). Thanks Chu Yeow! > > jeremy --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
