On Jan 12, 2008 3:26 PM, Michael Koziarski <[EMAIL PROTECTED]> wrote: > > The special-case nature of 'application.rb' is a bit of a smell, and > judging by the torrent of +1 votes on this ticket, there are a lot of > people who feel that way. > > http://dev.rubyonrails.org/ticket/10570
I still find it confusing that the class ApplicationController resides in a file called application.rb, not following the class/file naming convention used elsewhere. But I also find it confusing that it's called ApplicationController to begin with, given that it doesn't expose any actions and I never route to it. It's simply a base class for application-wide functionality. So why not call it Application? Controller superclasses don't have to use the Controller prefix, as evident by ApplicationController::Base. Assaf -- http://labnotes.org > So, if we want to ship something like this in 2.1 we should make sure > it's going to work well. So in addition to renaming the file in newly > generated applications, we'll need to have a strategy for people > upgrading from earlier versions. > > Ideally rake rails:update would be able to warn the user that the file > needs to be renamed, if not do the rename itself. If possible it'd > be nice to support both names for a while in trunk to avoid any > surprises for people running on edge[1]. > > Will this change enable any new 'stuff' that at present you can't do? > Referencing controllers from production.rb being the obvious case. > > Finally, as we'd no longer be preloading ApplicationController, is > there anything which might be relying on this? > > I'm definitely keen on fixing it up, I'm just worried that a torrent > of empty +1s may swamp any back-and-forth about the risks and benefits > to making the change. > > [1] I think you're crazy to be running on edge right now, but some > people like it :) > > -- > Cheers > > Koz > > > > -- -- Assaf http://labnotes.org --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
