On Jan 31, 2008 6:17 AM, Peter <[EMAIL PROTECTED]> wrote: > > > > On Jan 26, 7:09 am, Frederick Cheung <[EMAIL PROTECTED]> > wrote: > > On 26 Jan 2008, at 03:11, Peter wrote: > > > > > parents will return [nil, #<HumanResource::Person::Position id: 2, > > > person_id: 10001, position_id: 4, void_cheque: 0, hired_on: nil, > > > terminated_on: nil>] > > > > > The issue is when the preload of the association takes place, one of > > > the models returns nothing, the first element, and this creates an > > > error on line 25. To fix this, I simply added ".compact" to the end of > > > line 23. Unfortunately I don't have experience messing around with the > > > Rails core or writing unit tests for it so I wasn't able to formalize > > > this issue. > > > > That sounds about right (blame me, I wrote all that stuff :-). > > There's actually already a patch > > athttp://dev.rubyonrails.org/attachment/ticket/9640 > > that addresses this and some other issues. > > > > Fred > > Hi Fred, > > I looked over your patch, and its been sometime now that its been > sitting in the pending patches, what is taking so long for it to be > merged with the trunk? It's certainly an issue for anyone using edge > and eager loading.
I'm a little confused what the status is of the patches attached to 9640, perhaps consolidating them into another patch ticket for review would save everyone some time and hassle? -- Cheers Koz --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
