On Thu, Feb 14, 2008 at 4:33 AM, Tammer Saleh <[EMAIL PROTECTED]> wrote: > > I'd personally love to see #toggle! removed from ActiveRecord > entirely. I can't think of a single use case for #toggle! that isn't > bug-prone, or that wouldn't be better implemented by setting flags to > explicit values.
I heartily second this. I haven't used it since I ran into a situation where I was mis-guessing the initial state of a boolean. ::Jack Danger > On Feb 13, 5:18 am, Jan De Poorter <[EMAIL PROTECTED]> wrote: > > ActiveRecord::Base#toggle! is used to toggle an attribute true or > > false, and immediatly save it. It is implemented to call the toggle > > method, and then call update_attribute to save to the database. > > > > The problem I see with this is that there is no validation, when > > toggling a boolean. In my opinion this is wrong, and there should be > > validation. I've heard people say this behaviour was correct, and > > that's how they wanted it, in which case the documentation is > > incomplete and can lead to unexpected results. > > > > def toggle!(attribute) toggle(attribute).update_attribute(attribute, > > self[attribute]) end > > You tell me, a patch to make toggle! validate or a documentation patch > > to say toggle! doesn't validate when saving. > > > > I have a ticket open athttp://dev.rubyonrails.org/ticket/11098about > > this. > > > > Regards, > > > > Jan > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
