This is strange, I wasn't probably running all tests. I will take a deeper look into it!
On Jun 2, 2:24 pm, Pratik <[EMAIL PROTECTED]> wrote: > Fair enough. > > Cannot apply the patch as I'm gettin about 25 actionpack test failures/errors > :) > > > > On Mon, Jun 2, 2008 at 1:12 PM, José Valim <[EMAIL PROTECTED]> wrote: > > > I'm using it with Erubis and it's very handy! > > > If the point is accept many template handlers, that flexibility is > > needed. > > Otherwise I would need to hack any new template installed. > > > On Jun 2, 1:50 pm, Pratik <[EMAIL PROTECTED]> wrote: > >> I am curious to know why you need to change the value of > >> ActionView::Base.erb_variable ? I'm more inclined towards removing > >> that configuration option altogether. > > >> On Mon, Jun 2, 2008 at 12:39 PM, José Valim <[EMAIL PROTECTED]> wrote: > > >> > If we change ActionView::Base.erb_variable, cache_fragment doesn't > >> > work and some javascript functions also, because they are checking for > >> > the existence of '_erbout' instead of the variable set in > >> > erb_variable. > > >> > It's just a small patch, that fix javascript functions and send > >> > erb_variable to Erb.new(). > > >> > I also added the line below in fragment cache tests setup to assure > >> > that they are working with any variable set: > > >> > ActionView::Base.erb_variable = '_buf' > > >> > Patch here: > >> >http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/29... > > >> -- > >> Cheers! > >> - Pratikhttp://m.onkey.org > > -- > Cheers! > - Pratikhttp://m.onkey.org --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
