I've given up trying to patch the first one Frederick Cheung wanted (1104-references_eager_loaded_tables-should-search-tables-in-join- clauses), in favor of this approach:
http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/1185-old-single-query-includes-should-be-globally-disableable Patch and doc is submitted, can we get this reviewed/committed? -David Stevenson On Oct 6, 4:18 pm, Frederick Cheung <[EMAIL PROTECTED]> wrote: > On 6 Oct 2008, at 23:14, Will Bryant wrote: > > > On Tue, Oct 7, 2008 at 5:38 AM, Pratik <[EMAIL PROTECTED]> wrote: > > So before 2.2.RC1 is pushed, if you think any features should make it > > in, please let your voices be heard. Same goes for any critical bug > > fixes. If you have any pending patches that you want in 2.2, speak > > now. > > > My patch on #1110, please. It's a regression introduced in 2.1, and > > the patch is fairly straightforward. > > That was one i was thinking of. Another > washttp://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/11... > which turns out not to have a patch yet. > > Finally, a small patch of my > own:http://rails.lighthouseapp.com/attachments/46336/0001-enable-use-of-s... > (which personally I mostly want because I've been working on > making :include of hmt a bit leaner and need that patch to cover all > cases) > > Fred --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
