I'm not a fan of the platform/implementation conditions. When I did the SQL Server adapter, I found it very easy to use ruby to coerce the tests that I needed to. See the links below and you can see how I did this with a simple method_added hook. This leaves core to do what they want and focus on corey things and we can use ruby to do what we need to :)
http://github.com/rails-sqlserver/2000-2005-adapter/tree/master http://github.com/rails-sqlserver/2000-2005-adapter/tree/master/test/cases/sqlserver_helper.rb#L41 - Ken On Dec 31, 2008, at 3:47 PM, Stephen Bannasch wrote: > > I've got a patch to the AR tests that support running them in JRuby. > Right now the patch only works for mysql. > > A big part of the reason I'm working on this is to make it easier to > test JRuby itself. Charlie Nutter just fixed yesterday JRuby > regression that caused these tests to crash yesterday. If I can make > it easier to run these tests in JRuby we'll find and fix these > problems faster. > > Here's an example of a problem in JRuby I found: > > http://jira.codehaus.org/browse/JRUBY-3270 > > The problem was related to hpricot using a deprecated and then > deleted JRuby method that was part of it's implementation of fast_xs. > AS uses fast_xs if it is present ... > > http://jira.codehaus.org/browse/JRUBY-3272 > > I run the AR mysql jdbc tests like this: > > $ jruby -S rake test_jdbcmysql > > I've got the patch up here and a listing of what errors are > occurring now: > > http://pastie.org/349823 > > Is anybody else working on something like this. > > I was planning to implement the same pattern for other d adapters > available via jdbc and then submit a patch to rails. > > Is this something the core team would be interested in seeing in the > codebase? > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
