See? Because of me, now they have a warning. On 12/03/2009, at 5:35 AM, Pratik wrote:
> > Agree with Josh. Let's refrain from "good to have" stuff and focus on > the "must have" patches. > > On Wed, Mar 11, 2009 at 6:32 PM, Josh Susser > <[email protected]> wrote: >> >> This seems more like a feature addition and less like a bug fix. I'd >> say hold off until after the release for it. >> >> --josh >> >> On Mar 11, 2009, at 10:55 AM, Jason King wrote: >> >>> >>> Also, this one fixes kind-of a bug: >>> >>> http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/2162-layout-chaining >>> >>> At the moment, if you put two layout calls with options into a >>> controller, then the options will be merged together, but the >>> template >>> name will be last-in-wins. This can be confusing, and the docs >>> don't >>> actually say not to put two layout calls in one controller, AND the >>> layout guide actually gives this as an example of usage. >>> >>> Instead of fixing the guide, I thought it was a nice idea to have >>> multiple layout methods, so I wrote this patch - which also fixes >>> the >>> kind-of bug of conditions being merged but layout names being >>> overwritten. >>> >>> >>> On 09/03/2009, at 11:03 PM, Pratik wrote: >>> >>>> >>>> Hey all, >>>> >>>> As 2.3 RC2 is out, the plan is to have the 2.3 final release out >>>> as >>>> early as possible. So we'd like to make the last call for >>>> patches. If >>>> you have any pending patches that you want in 2.3 final release, >>>> please speak now. Not very keen on accepting refactoring patches or >>>> new features at this point as they can wait. But if there are any >>>> critical bug fixes or anything that should block the release, do >>>> post >>>> it in the replies. >>>> >>>> Thanks for all the contributions. 2.3 is looking really solid ! >>>> >>>> -- >>>> Cheers! >>>> - Pratik >>>> http://m.onkey.org >>>> >>>>> >>> >>> >>>> >> >> -- >> Josh Susser >> http://blog.hasmanythrough.com >> Golden Gate Ruby Conf :: April 17-18 :: http://gogaruco.com >> >> >> >> >>> >> > > > > -- > Cheers! > - Pratik > http://m.onkey.org > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
